Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 1035343002: Fix sourcemap after changes in source_span (Closed)

Created:
5 years, 9 months ago by Siggi Cherem (dart-lang)
Modified:
5 years, 9 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/source_maps@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/source_map_span.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pubspec.yaml View 1 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Siggi Cherem (dart-lang)
5 years, 9 months ago (2015-03-27 22:45:54 UTC) #2
nweiz
lgtm https://codereview.chromium.org/1035343002/diff/20001/pubspec.yaml File pubspec.yaml (right): https://codereview.chromium.org/1035343002/diff/20001/pubspec.yaml#newcode8 pubspec.yaml:8: source_span: ^1.1.1 If you're using "^"-style constraints, make ...
5 years, 9 months ago (2015-03-28 00:10:16 UTC) #3
Siggi Cherem (dart-lang)
https://codereview.chromium.org/1035343002/diff/20001/pubspec.yaml File pubspec.yaml (right): https://codereview.chromium.org/1035343002/diff/20001/pubspec.yaml#newcode8 pubspec.yaml:8: source_span: ^1.1.1 On 2015/03/28 00:10:16, nweiz wrote: > If ...
5 years, 9 months ago (2015-03-28 00:38:14 UTC) #4
Siggi Cherem (dart-lang)
5 years, 9 months ago (2015-03-28 00:39:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
ec6978e502bec1bdd7fb2f7aee33addf446d7c10 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698