Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1034813004: Add code to contextualize a span relative to its original source file. (Closed)

Created:
5 years, 9 months ago by nweiz
Modified:
5 years, 9 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/unittest@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add code to contextualize a span relative to its original source file. R=kevmoo@google.com Committed: https://github.com/dart-lang/unittest/commit/0786b175a2579182656185fa50264b6888f66a18

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+558 lines, -2 lines) Patch
M lib/src/runner/parse_metadata.dart View 1 chunk +11 lines, -2 lines 0 comments Download
M lib/src/util/dart.dart View 2 chunks +46 lines, -0 lines 0 comments Download
A lib/src/util/string_literal_iterator.dart View 1 chunk +245 lines, -0 lines 0 comments Download
M test/runner/runner_test.dart View 1 chunk +13 lines, -0 lines 0 comments Download
A test/util/string_literal_iterator_test.dart View 1 chunk +243 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 9 months ago (2015-03-26 00:56:37 UTC) #1
kevmoo
lgtm
5 years, 9 months ago (2015-03-26 06:11:00 UTC) #2
nweiz
5 years, 9 months ago (2015-03-26 21:54:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0786b175a2579182656185fa50264b6888f66a18 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698