Issue 103403007: Remove reference to ucontext_t

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 103403007: Remove reference to ucontext_t (Closed)

Created:
7 years ago by Cutch

Modified:
7 years ago

Reviewers:
zra

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove reference to ucontext_t until other Signal related functions on Android are implemented. Committed: https://code.google.com/p/dart/source/detail?r=31173

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -9 lines)			Patch
	M	runtime/vm/thread_interrupter_android.cc	View		1 chunk	+0 lines, -9 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

zra

7 years ago (2013-12-16 21:08:05 UTC) #3

Message was sent while issue was closed.

lgtm

Android build succeeds

https://codereview.chromium.org/103403007/diff/20001/runtime/vm/thread_interr...
File runtime/vm/thread_interrupter_android.cc (right):

https://codereview.chromium.org/103403007/diff/20001/runtime/vm/thread_interr...
runtime/vm/thread_interrupter_android.cc:29: ASSERT(Thread::Compare(state->id,
Thread::GetCurrentThreadId()));
Please add a comment somewhere (not necessarily here) with a TODO pointing to
the V8 source file where they set up these types for Android.

Expand Messages | Collapse Messages