pkg/isolate: refactoring http_server example to use async/await

refactoring http_server example to use async/await

R=lrn@google.com

Committed: https://github.com/dart-lang/isolate/commit/2bf5a19bb037cd73cf08ff91ea02850edfe9e457

[kevmoo, 2015-03-24 21:53:38]

kevmoo@google.com changed reviewers:
+ lrn@google.com

[kevmoo, 2015-03-24 21:53:39]

https://codereview.chromium.org/1033843002/diff/1/example/http_server.dart
File example/http_server.dart (right):

https://codereview.chromium.org/1033843002/diff/1/example/http_server.dart#ne...
example/http_server.dart:19: var stopPort = await runner.run(_startHttpServer,
new List(2)
I get the benefit of fixed-length lists, but in this case would
[socket.reference, listener] be okay?

https://codereview.chromium.org/1033843002/diff/1/example/http_server.dart#ne...
example/http_server.dart:63: Future start(HttpServer server) async {
Using async here instead of returning `new Future.value(null)` or similar.

https://codereview.chromium.org/1033843002/diff/1/example/http_server.dart#ne...
example/http_server.dart:115: print("  ab -l -c10 -n $count
http://localhost:$port/");
Added "-l" so changes in length don't cause errors to be reported. Important in
the 1/10 chance hashCode isn't the max length.

[Lasse Reichstein Nielsen, 2015-03-25 17:56:57]

lgtm

https://codereview.chromium.org/1033843002/diff/1/example/http_server.dart
File example/http_server.dart (right):

https://codereview.chromium.org/1033843002/diff/1/example/http_server.dart#ne...
example/http_server.dart:19: var stopPort = await runner.run(_startHttpServer,
new List(2)
It's just a sample, so yes, it'll be fine.

https://codereview.chromium.org/1033843002/diff/1/example/http_server.dart#ne...
example/http_server.dart:63: Future start(HttpServer server) async {
That's fine. I fully expect to see every Future-returning function be written
using async/await in user code.

Maybe my library code will follow when performance gets better :)

https://codereview.chromium.org/1033843002/diff/20001/example/http_server.dart
File example/http_server.dart (right):

https://codereview.chromium.org/1033843002/diff/20001/example/http_server.dar...
example/http_server.dart:32: var server = await
HttpServer.bind(InternetAddress.ANY_IP_V6, port, shared: true);
Long line.

[kevmoo, 2015-03-26 07:57:34]

https://codereview.chromium.org/1033843002/diff/1/example/http_server.dart
File example/http_server.dart (right):

https://codereview.chromium.org/1033843002/diff/1/example/http_server.dart#ne...
example/http_server.dart:19: var stopPort = await runner.run(_startHttpServer,
new List(2)
On 2015/03/25 17:56:57, Lasse Reichstein Nielsen wrote:
> It's just a sample, so yes, it'll be fine.

Acknowledged.

https://codereview.chromium.org/1033843002/diff/20001/example/http_server.dart
File example/http_server.dart (right):

https://codereview.chromium.org/1033843002/diff/20001/example/http_server.dar...
example/http_server.dart:32: var server = await
HttpServer.bind(InternetAddress.ANY_IP_V6, port, shared: true);
On 2015/03/25 17:56:57, Lasse Reichstein Nielsen wrote:
> Long line.

Done.

[kevmoo, 2015-03-26 07:57:47]

Committed patchset #3 (id:40001) manually as
2bf5a19bb037cd73cf08ff91ea02850edfe9e457 (presubmit successful).