Separate is_debuggable and is_visible again. The outer async functions

Separate is_debuggable and is_visible again. The outer async functions (that produce the Futures or Streams) should be visible but not debuggable. Visible so their frames are included in stacktraces for return type errors during checked mode. Not debuggable so breakpoints are resolved to the function that implements the async body.

BUG=http://dartbug.com/22891
R=hausner@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44646

[rmacnak, 2015-03-23 19:32:09]

rmacnak@google.com changed reviewers:
+ hausner@google.com

[hausner, 2015-03-23 19:38:25]

LGTM with a couple of comments.

https://codereview.chromium.org/1033483002/diff/20001/runtime/vm/object.h
File runtime/vm/object.h (right):

https://codereview.chromium.org/1033483002/diff/20001/runtime/vm/object.h#new...
runtime/vm/object.h:2265: V(Visible, is_visible)                                
                      \
Please add a description for the visible flag in the comment above.

https://codereview.chromium.org/1033483002/diff/20001/tests/language/async_or...
File tests/language/async_or_generator_return_type_stacktrace_test.dart (right):

https://codereview.chromium.org/1033483002/diff/20001/tests/language/async_or...
tests/language/async_or_generator_return_type_stacktrace_test.dart:15:
Expect.isTrue(e is TypeError, "wrong exception");
"unexpected exception type" might be more descriptive

[rmacnak, 2015-03-23 20:25:35]

https://codereview.chromium.org/1033483002/diff/20001/runtime/vm/object.h
File runtime/vm/object.h (right):

https://codereview.chromium.org/1033483002/diff/20001/runtime/vm/object.h#new...
runtime/vm/object.h:2265: V(Visible, is_visible)                                
                      \
On 2015/03/23 19:38:25, hausner wrote:
> Please add a description for the visible flag in the comment above.

Done.

https://codereview.chromium.org/1033483002/diff/20001/tests/language/async_or...
File tests/language/async_or_generator_return_type_stacktrace_test.dart (right):

https://codereview.chromium.org/1033483002/diff/20001/tests/language/async_or...
tests/language/async_or_generator_return_type_stacktrace_test.dart:15:
Expect.isTrue(e is TypeError, "wrong exception");
On 2015/03/23 19:38:25, hausner wrote:
> "unexpected exception type" might be more descriptive

Done.

[rmacnak, 2015-03-23 20:26:21]

Committed patchset #3 (id:40001) manually as 44646 (presubmit successful).