Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1033383002: Gracefully handle IO exceptions while resolving URIs (issue 23023) (Closed)

Created:
5 years, 9 months ago by Brian Wilkerson
Modified:
5 years, 9 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Gracefully handle IO exceptions while resolving URIs (issue 23023) R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=44766

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -5 lines) Patch
M pkg/analyzer/lib/src/generated/engine.dart View 3 chunks +9 lines, -5 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 2 chunks +27 lines, -0 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
Brian Wilkerson
5 years, 9 months ago (2015-03-27 22:15:27 UTC) #2
scheglov
LGTM https://codereview.chromium.org/1033383002/diff/1/pkg/analyzer/test/generated/engine_test.dart File pkg/analyzer/test/generated/engine_test.dart (right): https://codereview.chromium.org/1033383002/diff/1/pkg/analyzer/test/generated/engine_test.dart#newcode4654 pkg/analyzer/test/generated/engine_test.dart:4654: expect(listener.errors.length, 1); expect(listener.errors, hasLength(1));
5 years, 9 months ago (2015-03-27 23:05:58 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/1033383002/diff/1/pkg/analyzer/test/generated/engine_test.dart File pkg/analyzer/test/generated/engine_test.dart (right): https://codereview.chromium.org/1033383002/diff/1/pkg/analyzer/test/generated/engine_test.dart#newcode4654 pkg/analyzer/test/generated/engine_test.dart:4654: expect(listener.errors.length, 1); Done
5 years, 9 months ago (2015-03-27 23:51:58 UTC) #4
Brian Wilkerson
5 years, 9 months ago (2015-03-27 23:52:18 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 44766 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698