Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 1033333003: improve parser recovery for incomplete prefixed identifier in method/function parameter list (Closed)

Created:
5 years, 9 months ago by danrubel
Modified:
5 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

improve parser recovery for incomplete prefixed identifier in method/function parameter list BUG=dartbug.com/22526 R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=44760

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -1 line) Patch
M pkg/analysis_server/test/services/completion/completion_target_test.dart View 1 chunk +24 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 1 chunk +27 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/optype_test.dart View 1 chunk +18 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 1 chunk +12 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
5 years, 9 months ago (2015-03-27 19:57:56 UTC) #2
Brian Wilkerson
LGTM
5 years, 9 months ago (2015-03-27 20:02:40 UTC) #3
danrubel
5 years, 9 months ago (2015-03-27 20:05:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44760 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698