Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1033213002: Fix type annotation for deferred constants. (Closed)

Created:
5 years, 9 months ago by Johnni Winther
Modified:
5 years, 9 months ago
Reviewers:
karlklose, sigurdm
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Fix type annotation for deferred constants. BUG= R=sigurdm@google.com Committed: https://code.google.com/p/dart/source/detail?r=44730

Patch Set 1 #

Patch Set 2 : Skip deferred for dart2dart #

Total comments: 2

Patch Set 3 : Update cf. comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -88 lines) Patch
M pkg/compiler/lib/src/resolution/semantic_visitor.dart View 18 chunks +18 lines, -18 lines 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart View 43 chunks +43 lines, -43 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_resolver.dart View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolved_visitor.dart View 6 chunks +6 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test.dart View 18 chunks +18 lines, -18 lines 0 comments Download
M tests/language/language_dart2js.status View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Johnni Winther
5 years, 9 months ago (2015-03-27 09:52:07 UTC) #2
sigurdm
LGTM
5 years, 9 months ago (2015-03-27 10:04:30 UTC) #3
karlklose
DBC: https://codereview.chromium.org/1033213002/diff/20001/pkg/compiler/lib/src/resolution/send_resolver.dart File pkg/compiler/lib/src/resolution/send_resolver.dart (right): https://codereview.chromium.org/1033213002/diff/20001/pkg/compiler/lib/src/resolution/send_resolver.dart#newcode312 pkg/compiler/lib/src/resolution/send_resolver.dart:312: // TODO(johnniwinther): Handle deferred constants. Could you explain ...
5 years, 9 months ago (2015-03-27 10:05:05 UTC) #5
Johnni Winther
Committed patchset #3 (id:40001) manually as 44730 (presubmit successful).
5 years, 9 months ago (2015-03-27 10:27:26 UTC) #6
Johnni Winther
5 years, 9 months ago (2015-03-28 15:14:31 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/1033213002/diff/20001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolution/send_resolver.dart (right):

https://codereview.chromium.org/1033213002/diff/20001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/send_resolver.dart:312: // TODO(johnniwinther):
Handle deferred constants.
On 2015/03/27 10:05:05, karlklose wrote:
> Could you explain on what is the problem/missing for deferred constants?

Done.

Powered by Google App Engine
This is Rietveld 408576698