Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 1032623005: pkg/shelf: spelling fixes (Closed)

Created:
5 years, 9 months ago by kevmoo
Modified:
5 years, 9 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/shelf.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M CHANGELOG.md View 1 chunk +4 lines, -0 lines 2 comments Download
M README.md View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/cascade.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/handlers/logger.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/message.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/shelf_unmodifiable_map.dart View 1 chunk +1 line, -1 line 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 3 comments Download

Messages

Total messages: 7 (1 generated)
kevmoo
5 years, 9 months ago (2015-03-24 17:31:26 UTC) #2
nweiz
https://codereview.chromium.org/1032623005/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/1032623005/diff/1/CHANGELOG.md#newcode1 CHANGELOG.md:1: ## 0.6.1 This should be 0.6.0+1. 0.6.1 would imply ...
5 years, 9 months ago (2015-03-24 20:00:33 UTC) #3
kevmoo
https://codereview.chromium.org/1032623005/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/1032623005/diff/1/CHANGELOG.md#newcode1 CHANGELOG.md:1: ## 0.6.1 On 2015/03/24 20:00:33, nweiz wrote: > This ...
5 years, 9 months ago (2015-03-24 20:03:49 UTC) #4
nweiz
lgtm https://codereview.chromium.org/1032623005/diff/1/pubspec.yaml File pubspec.yaml (right): https://codereview.chromium.org/1032623005/diff/1/pubspec.yaml#newcode2 pubspec.yaml:2: version: 0.6.1-dev On 2015/03/24 20:03:49, kevmoo wrote: > ...
5 years, 9 months ago (2015-03-24 20:17:05 UTC) #5
kevmoo
On 2015/03/24 20:17:05, nweiz wrote: > lgtm > > https://codereview.chromium.org/1032623005/diff/1/pubspec.yaml > File pubspec.yaml (right): > ...
5 years, 9 months ago (2015-03-24 20:20:33 UTC) #6
kevmoo
5 years, 9 months ago (2015-03-24 20:20:49 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
57705e17b2b35ba148c6ded0479dc3371c1fb0cf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698