dart2js: Optimize Function.apply for 0-3 argument calls.

dart2js: Optimize Function.apply for 0-3 argument calls.

R=sra@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44704

[floitsch, 2015-03-25 01:37:32]

floitsch@google.com changed reviewers:
+ sra@google.com

[sra1, 2015-03-25 03:16:29]

lgtm

https://codereview.chromium.org/1032013002/diff/1/sdk/lib/_internal/compiler/...
File sdk/lib/_internal/compiler/js_lib/js_helper.dart (right):

https://codereview.chromium.org/1032013002/diff/1/sdk/lib/_internal/compiler/...
sdk/lib/_internal/compiler/js_lib/js_helper.dart:1181: arguments[0],
arguments[1], arguments[2]);
I would not surprise me if the array bounds checks were not optimized.
Running with --trust-primitives would be misleading.
Safer to use:

JS('', '#[#](#[0],#[1],#[2])', function, selectorName,
  arguments, arguments, arguments);

[floitsch, 2015-03-25 22:58:30]

https://codereview.chromium.org/1032013002/diff/1/sdk/lib/_internal/compiler/...
File sdk/lib/_internal/compiler/js_lib/js_helper.dart (right):

https://codereview.chromium.org/1032013002/diff/1/sdk/lib/_internal/compiler/...
sdk/lib/_internal/compiler/js_lib/js_helper.dart:1181: arguments[0],
arguments[1], arguments[2]);
On 2015/03/25 03:16:29, sra1 wrote:
> I would not surprise me if the array bounds checks were not optimized.
> Running with --trust-primitives would be misleading.
> Safer to use:
> 
> JS('', '#[#](#[0],#[1],#[2])', function, selectorName,
>   arguments, arguments, arguments);

I was sure I had tested it, but you are (unfortunately) right.
done.

[floitsch, 2015-03-25 23:21:32]

Committed patchset #2 (id:20001) manually as 44704 (presubmit successful).