Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(991)

Issue 1031993002: dart2js: permit generation of conditionals as arguments of allocations. (Closed)

Created:
5 years, 9 months ago by sra1
Modified:
5 years, 9 months ago
Reviewers:
herhut
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: permit generation of conditionals as arguments of allocations. Example: t1 = onError == null ? 1 : 3; this._addListener$1(new P._FutureListener(null, result, t1, f, onError)); --> this._addListener$1(new P._FutureListener(null, result, onError == null ? 1 : 3, f, onError)); R=herhut@google.com Committed: https://code.google.com/p/dart/source/detail?r=44696

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M pkg/compiler/lib/src/ssa/codegen_helpers.dart View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
sra1
5 years, 9 months ago (2015-03-24 23:47:32 UTC) #2
herhut
lgtm
5 years, 9 months ago (2015-03-25 10:02:45 UTC) #3
sra1
5 years, 9 months ago (2015-03-25 20:18:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44696 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698