Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1031673004: Caches the edge counter increment size in the isolate() (Closed)

Created:
5 years, 9 months ago by zra
Modified:
5 years, 9 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Caches the edge counter increment size in the isolate() As suggested in [1], hardcoding the lengths is too fragile. [1] https://codereview.chromium.org/975643003/ R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=44648

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -67 lines) Patch
M runtime/vm/flow_graph_compiler_arm.cc View 2 chunks +9 lines, -29 lines 2 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 1 chunk +7 lines, -19 lines 1 comment Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 chunk +7 lines, -19 lines 0 comments Download
M runtime/vm/isolate.h View 2 chunks +10 lines, -0 lines 0 comments Download
M runtime/vm/isolate.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
zra
5 years, 9 months ago (2015-03-23 20:18:49 UTC) #2
srdjan
lgtm https://codereview.chromium.org/1031673004/diff/1/runtime/vm/flow_graph_compiler_arm.cc File runtime/vm/flow_graph_compiler_arm.cc (right): https://codereview.chromium.org/1031673004/diff/1/runtime/vm/flow_graph_compiler_arm.cc#newcode1219 runtime/vm/flow_graph_compiler_arm.cc:1219: int32_t FlowGraphCompiler::EdgeCounterIncrementSizeInBytes() { const
5 years, 9 months ago (2015-03-23 20:28:08 UTC) #3
zra
https://codereview.chromium.org/1031673004/diff/1/runtime/vm/flow_graph_compiler_arm.cc File runtime/vm/flow_graph_compiler_arm.cc (right): https://codereview.chromium.org/1031673004/diff/1/runtime/vm/flow_graph_compiler_arm.cc#newcode1219 runtime/vm/flow_graph_compiler_arm.cc:1219: int32_t FlowGraphCompiler::EdgeCounterIncrementSizeInBytes() { On 2015/03/23 20:28:08, srdjan wrote: > ...
5 years, 9 months ago (2015-03-23 20:31:16 UTC) #4
zra
Committed patchset #1 (id:1) manually as r44648 (presubmit successful).
5 years, 9 months ago (2015-03-23 21:26:21 UTC) #5
Ivan Posva
5 years, 9 months ago (2015-03-24 02:54:13 UTC) #7
Message was sent while issue was closed.
DBC -ip

https://codereview.chromium.org/1031673004/diff/1/runtime/vm/flow_graph_compi...
File runtime/vm/flow_graph_compiler_ia32.cc (right):

https://codereview.chromium.org/1031673004/diff/1/runtime/vm/flow_graph_compi...
runtime/vm/flow_graph_compiler_ia32.cc:1247: int32_t
FlowGraphCompiler::EdgeCounterIncrementSizeInBytes() {
This function should now move to flow_graph_compiler.cc.

Powered by Google App Engine
This is Rietveld 408576698