Almost-constant interceptors

Avoid getInterceptor calls in cases were the interceptor would be constant if it were not `null`.

Example:

    gap = J.getInterceptor$x(style).get$columnGap(style);
-->
    gap = (style && C.CssStyleDeclaration_methods).get$columnGap(style);

R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44853

[sra1, 2015-03-24 03:09:40]

sra@google.com changed reviewers:
+ floitsch@google.com

[sra1, 2015-03-25 05:27:56]

This is work in progress as I investigate getInterceptor calls.

[floitsch, 2015-03-26 20:26:45]

LG so far.

https://chromiumcodereview.appspot.com/1031633003/diff/1/pkg/compiler/lib/src...
File pkg/compiler/lib/src/ssa/interceptor_simplifier.dart (right):

https://chromiumcodereview.appspot.com/1031633003/diff/1/pkg/compiler/lib/src...
pkg/compiler/lib/src/ssa/interceptor_simplifier.dart:295: if
(!(receiver.canBePrimitiveNumber(compiler) ||
Why this `if`?

https://chromiumcodereview.appspot.com/1031633003/diff/1/pkg/compiler/lib/src...
File pkg/compiler/lib/src/ssa/nodes.dart (right):

https://chromiumcodereview.appspot.com/1031633003/diff/1/pkg/compiler/lib/src...
pkg/compiler/lib/src/ssa/nodes.dart:2304: // inputs[0] is initially the only
input, the receiver.
Create getters.

[sra1, 2015-04-01 23:06:35]

Patchset #2 (id:20001) has been deleted

[sra1, 2015-04-01 23:06:59]

PTAL

https://chromiumcodereview.appspot.com/1031633003/diff/1/pkg/compiler/lib/src...
File pkg/compiler/lib/src/ssa/interceptor_simplifier.dart (right):

https://chromiumcodereview.appspot.com/1031633003/diff/1/pkg/compiler/lib/src...
pkg/compiler/lib/src/ssa/interceptor_simplifier.dart:295: if
(!(receiver.canBePrimitiveNumber(compiler) ||
On 2015/03/26 20:26:45, floitsch wrote:
> Why this `if`?

Added comment.  Only works for truthy values.

https://chromiumcodereview.appspot.com/1031633003/diff/1/pkg/compiler/lib/src...
File pkg/compiler/lib/src/ssa/nodes.dart (right):

https://chromiumcodereview.appspot.com/1031633003/diff/1/pkg/compiler/lib/src...
pkg/compiler/lib/src/ssa/nodes.dart:2304: // inputs[0] is initially the only
input, the receiver.
On 2015/03/26 20:26:45, floitsch wrote:
> Create getters.

Done.

[floitsch, 2015-04-01 23:14:54]

LGTM.

https://chromiumcodereview.appspot.com/1031633003/diff/40001/pkg/compiler/lib...
File pkg/compiler/lib/src/ssa/interceptor_simplifier.dart (right):

https://chromiumcodereview.appspot.com/1031633003/diff/40001/pkg/compiler/lib...
pkg/compiler/lib/src/ssa/interceptor_simplifier.dart:295: // Can only use
`(receiver && C)` if receiver is null or truthy.
is either null or truthy.

https://chromiumcodereview.appspot.com/1031633003/diff/40001/pkg/compiler/lib...
pkg/compiler/lib/src/ssa/interceptor_simplifier.dart:302: if (node.inputs.length
== 1) {
when can it have more than one? is it `node.isConditionalConstantInterceptor` ?
Maybe check it earlier? (it seems like a cheap check).

[sra1, 2015-04-02 00:59:34]

Committed patchset #3 (id:60001) manually as 44853 (presubmit successful).

[sra1, 2015-04-02 01:00:07]

https://chromiumcodereview.appspot.com/1031633003/diff/40001/pkg/compiler/lib...
File pkg/compiler/lib/src/ssa/interceptor_simplifier.dart (right):

https://chromiumcodereview.appspot.com/1031633003/diff/40001/pkg/compiler/lib...
pkg/compiler/lib/src/ssa/interceptor_simplifier.dart:295: // Can only use
`(receiver && C)` if receiver is null or truthy.
On 2015/04/01 23:14:54, floitsch wrote:
> is either null or truthy.

Done.

https://chromiumcodereview.appspot.com/1031633003/diff/40001/pkg/compiler/lib...
pkg/compiler/lib/src/ssa/interceptor_simplifier.dart:302: if (node.inputs.length
== 1) {
On 2015/04/01 23:14:54, floitsch wrote:
> when can it have more than one? is it `node.isConditionalConstantInterceptor`
?
> Maybe check it earlier? (it seems like a cheap check).

Done.