Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 1031393003: Make sure Observatory tests run for each commit. Fix broken tests. (Closed)

Created:
5 years, 9 months ago by turnidge
Modified:
5 years, 9 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, ricow1, Cutch, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Make sure Observatory tests run for each commit. Fix broken tests. BUG= R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=44714

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M runtime/observatory/test/contexts_test.dart View 3 chunks +15 lines, -3 lines 0 comments Download
M runtime/observatory/test/coverage_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/testing/dart/test_options.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
turnidge
5 years, 9 months ago (2015-03-26 17:32:14 UTC) #2
Cutch
lgtm
5 years, 9 months ago (2015-03-26 17:34:29 UTC) #3
turnidge
5 years, 9 months ago (2015-03-26 17:35:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44714 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698