Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 103083003: Make re-exported classes appear as if they are part of the original library. (Closed)

Created:
7 years ago by Emily Fortuna
Modified:
7 years ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make re-exported classes appear as if they are part of the original library. This is a WIP -- I need to finish the recursive updating of exported fields, but everything else should be there. BUG= R=alanknight@google.com Committed: https://code.google.com/p/dart/source/detail?r=30831

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -26 lines) Patch
M pkg/docgen/lib/docgen.dart View 14 chunks +175 lines, -26 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
Emily Fortuna
This fixes the bulk of the issue. More cleanup and the recursive visiting to be ...
7 years ago (2013-12-03 22:37:49 UTC) #1
Alan Knight
lgtm https://codereview.chromium.org/103083003/diff/20001/pkg/docgen/lib/docgen.dart File pkg/docgen/lib/docgen.dart (right): https://codereview.chromium.org/103083003/diff/20001/pkg/docgen/lib/docgen.dart#newcode907 pkg/docgen/lib/docgen.dart:907: /// Returns a [ClassGroup] containing error, typedef and ...
7 years ago (2013-12-03 22:48:06 UTC) #2
Emily Fortuna
7 years ago (2013-12-03 23:05:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r30831 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698