Task: BuildClassConstructorsTask.

Task: BuildClassConstructorsTask.

R=paulberry@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=44675

[Paul Berry, 2015-03-24 20:10:17]

lgtm for now, however see my concern below.

https://codereview.chromium.org/1029953002/diff/1/pkg/analyzer/lib/src/task/d...
File pkg/analyzer/lib/src/task/dart.dart (right):

https://codereview.chromium.org/1029953002/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:302: static Map<String, TaskInput>
buildInputs(ClassElement classElement) {
I think this is going to cause a problem in the long term.  We need an input
that ensures that the element's .supertype has been set before this task runs.

I'm not sure what the best solution to this problem is.  I have a few ideas but
none of them are pretty.

Adding Brian to the CC in case he has any ideas.

[scheglov, 2015-03-24 21:17:15]

https://codereview.chromium.org/1029953002/diff/1/pkg/analyzer/lib/src/task/d...
File pkg/analyzer/lib/src/task/dart.dart (right):

https://codereview.chromium.org/1029953002/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:302: static Map<String, TaskInput>
buildInputs(ClassElement classElement) {
On 2015/03/24 20:10:17, Paul Berry wrote:
> I think this is going to cause a problem in the long term.  We need an input
> that ensures that the element's .supertype has been set before this task runs.
> 
> I'm not sure what the best solution to this problem is.  I have a few ideas
but
> none of them are pretty.
> 
> Adding Brian to the CC in case he has any ideas.

I will add TODO for now.
We need to discuss it when we are all in the office.

[scheglov, 2015-03-24 21:20:23]

Committed patchset #2 (id:20001) manually as 44675 (presubmit successful).