Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 1029853002: Fix implementation of Function.apply with optional positional arguments. (Closed)

Created:
5 years, 9 months ago by herhut
Modified:
5 years, 9 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, Lasse Reichstein Nielsen
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Fix implementation of Function.apply with optional positional arguments. BUG= R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=44666

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M sdk/lib/_internal/compiler/js_lib/js_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/apply4_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
herhut
5 years, 9 months ago (2015-03-24 14:00:54 UTC) #1
herhut
[+ lrn]
5 years, 9 months ago (2015-03-24 14:01:50 UTC) #2
karlklose
LGTM.
5 years, 9 months ago (2015-03-24 14:06:07 UTC) #3
herhut
5 years, 9 months ago (2015-03-24 14:17:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44666 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698