Issue 102973007: Constant propagation in LoadIndexed when inputs are array/string and index constants.

Issue 102973007: Constant propagation in LoadIndexed when inputs are array/string and index constants. (Closed)

Created:
7 years ago by srdjan

Modified:
7 years ago

Reviewers:
Florian Schneider, Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Kevin Millikin (Google)

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Constant propagation in LoadIndexed when inputs are array/string and index constants. R=fschneider@google.com, johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=31230

Patch Set 2 : #

Total comments: 2

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -2 lines)			Patch
M	runtime/vm/flow_graph_optimizer.cc	View	1	1 chunk	+31 lines, -1 line	2 comments	Download
M	tests/language/guess_cid_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
A	tests/language/load_indexed_constant_test.dart	View		1 chunk	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Cutch

lgtm with comment https://codereview.chromium.org/102973007/diff/20001/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/102973007/diff/20001/runtime/vm/flow_graph_optimizer.cc#newcode6654 runtime/vm/flow_graph_optimizer.cc:6654: if ((a.Length() > index) && a.IsImmutable()) ...

7 years ago (2013-12-18 05:21:19 UTC) #3

srdjan

https://codereview.chromium.org/102973007/diff/20001/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/102973007/diff/20001/runtime/vm/flow_graph_optimizer.cc#newcode6654 runtime/vm/flow_graph_optimizer.cc:6654: if ((a.Length() > index) && a.IsImmutable()) { On 2013/12/18 ...

7 years ago (2013-12-18 16:40:00 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r31230 (presubmit successful).

Expand Messages | Collapse Messages