Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 102953008: Add getter for lineMode and echoMode for Stdin. (Closed)

Created:
7 years ago by Anders Johnsen
Modified:
7 years ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add getter for lineMode and echoMode for Stdin. BUG=https://code.google.com/p/dart/issues/detail?id=15424 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=31103

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -10 lines) Patch
M runtime/bin/io_natives.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M runtime/bin/stdin.h View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/bin/stdin.cc View 1 chunk +12 lines, -4 lines 0 comments Download
M runtime/bin/stdin_android.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M runtime/bin/stdin_linux.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M runtime/bin/stdin_macos.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M runtime/bin/stdin_win.cc View 2 chunks +16 lines, -0 lines 0 comments Download
M runtime/bin/stdio_patch.dart View 1 chunk +11 lines, -2 lines 0 comments Download
M sdk/lib/_internal/lib/io_patch.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M sdk/lib/io/stdio.dart View 2 chunks +12 lines, -2 lines 0 comments Download
M tests/standalone/io/stdin_sync_test.dart View 3 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
7 years ago (2013-12-12 16:37:11 UTC) #1
Søren Gjesse
lgtm
7 years ago (2013-12-12 16:41:47 UTC) #2
Anders Johnsen
7 years ago (2013-12-12 16:42:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r31103 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698