Issue 1029003003: Mark test as having static warnings for bad future implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1029003003: Mark test as having static warnings for bad future implementation. (Closed)

Created:
5 years, 9 months ago by Lasse Reichstein Nielsen

Modified:
5 years, 9 months ago

Reviewers:
Søren Gjesse, sigurdm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Mark test as having static warnings for bad future implementation. R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=44631

Patch Set 1 #

Total comments: 1

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	tests/lib/lib.status	View		1 chunk	+2 lines, -0 lines	1 comment	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Lasse Reichstein Nielsen

Committed patchset #1 (id:1) manually as 44631 (presubmit successful).

5 years, 9 months ago (2015-03-23 10:08:32 UTC) #4

sigurdm

5 years, 9 months ago (2015-03-24 07:13:06 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/1029003003/diff/1/tests/lib/lib.status
File tests/lib/lib.status (right):

https://codereview.chromium.org/1029003003/diff/1/tests/lib/lib.status#newcod...
tests/lib/lib.status:315: async/future_test: StaticWarning, OK # Deliberately
broken implementation.
DBC: Marking a test as having a static warning should probably be done through
the multitest framework.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages