Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1367)

Issue 1029003002: dart2js: remove first argument from lazy function. (Closed)

Created:
5 years, 9 months ago by zarah
Modified:
5 years, 8 months ago
Reviewers:
herhut
CC:
reviews_dartlang.org, floitsch, ahe
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Upload after rebase and revert. #

Patch Set 3 : Fixed incremental compiler case. #

Patch Set 4 : Removed new line. #

Total comments: 2

Patch Set 5 : Added comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -17 lines) Patch
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 1 2 3 4 6 chunks +28 lines, -16 lines 0 comments Download
M pkg/dart2js_incremental/lib/library_updater.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
zarah
5 years, 9 months ago (2015-03-23 09:45:52 UTC) #2
herhut
lgtm
5 years, 9 months ago (2015-03-24 09:34:05 UTC) #3
zarah
Committed patchset #1 (id:1) manually as 44660 (presubmit successful).
5 years, 9 months ago (2015-03-24 11:31:33 UTC) #4
zarah
PTAL
5 years, 9 months ago (2015-03-25 14:04:32 UTC) #5
herhut
lgtm w/ comments https://codereview.chromium.org/1029003002/diff/60001/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart File pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart (right): https://codereview.chromium.org/1029003002/diff/60001/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart#newcode1034 pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:1034: if (#needsLazyInitializer) { Please add a ...
5 years, 9 months ago (2015-03-25 14:23:14 UTC) #6
zarah
https://codereview.chromium.org/1029003002/diff/60001/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart File pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart (right): https://codereview.chromium.org/1029003002/diff/60001/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart#newcode1034 pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:1034: if (#needsLazyInitializer) { On 2015/03/25 14:23:14, herhut wrote: > ...
5 years, 9 months ago (2015-03-25 14:46:04 UTC) #7
zarah
5 years, 8 months ago (2015-03-30 08:19:32 UTC) #8
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as 44776 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698