Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Issue 1028453002: Support percent encoded data URIs in the standalone embedder. (Closed)

Created:
5 years, 9 months ago by rmacnak
Modified:
5 years, 9 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, sethladd, danrubel, keertip
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Support percent encoded data URIs in the standalone embedder. BUG= R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=44609

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : add negative tests, make multitest understand data uris, fix test in checked mode #

Total comments: 2

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -13 lines) Patch
M runtime/bin/builtin.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/loader.dart View 1 2 3 2 chunks +33 lines, -0 lines 0 comments Download
A runtime/tests/vm/dart/data_uri_failures_test.dart View 1 2 3 1 chunk +24 lines, -0 lines 0 comments Download
A + runtime/tests/vm/dart/data_uri_import_test.dart View 1 2 1 chunk +5 lines, -12 lines 0 comments Download
A runtime/tests/vm/dart/data_uri_spawn_test.dart View 1 2 3 1 chunk +30 lines, -0 lines 0 comments Download
M tools/testing/dart/multitest.dart View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
rmacnak
5 years, 9 months ago (2015-03-20 00:47:36 UTC) #2
Ivan Posva
LGTM with hopefully simple change of R to r. -Ivan https://codereview.chromium.org/1028453002/diff/60001/tools/testing/dart/multitest.dart File tools/testing/dart/multitest.dart (right): https://codereview.chromium.org/1028453002/diff/60001/tools/testing/dart/multitest.dart#newcode76 ...
5 years, 9 months ago (2015-03-20 19:54:58 UTC) #3
rmacnak
https://codereview.chromium.org/1028453002/diff/60001/tools/testing/dart/multitest.dart File tools/testing/dart/multitest.dart (right): https://codereview.chromium.org/1028453002/diff/60001/tools/testing/dart/multitest.dart#newcode76 tools/testing/dart/multitest.dart:76: : '\R\n'; On 2015/03/20 19:54:58, Ivan Posva wrote: > ...
5 years, 9 months ago (2015-03-20 20:11:28 UTC) #4
rmacnak
5 years, 9 months ago (2015-03-20 20:12:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as 44609 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698