pkg/isolate: fix checked-mode running of isolaterunner_test

fix checked-mode running of isolaterunner_test

R=lrn@google.com

Committed: https://github.com/dart-lang/isolate/commit/a286f690326c9f12511990e6fab3769365be4fea

[kevmoo, 2015-03-23 15:06:20]

kevmoo@google.com changed reviewers:
+ lrn@google.com

[Lasse Reichstein Nielsen, 2015-03-24 10:41:23]

lgtm

https://codereview.chromium.org/1028193003/diff/1/test/isolaterunner_test.dart
File test/isolaterunner_test.dart (right):

https://codereview.chromium.org/1028193003/diff/1/test/isolaterunner_test.dar...
test/isolaterunner_test.dart:114: setGlobal(v) => _global = v;
I prefer
  void setGlobal(v) { _global = v; }

[kevmoo, 2015-03-24 13:10:29]

https://codereview.chromium.org/1028193003/diff/1/test/isolaterunner_test.dart
File test/isolaterunner_test.dart (right):

https://codereview.chromium.org/1028193003/diff/1/test/isolaterunner_test.dar...
test/isolaterunner_test.dart:114: setGlobal(v) => _global = v;
On 2015/03/24 10:41:23, Lasse Reichstein Nielsen wrote:
> I prefer
>   void setGlobal(v) { _global = v; }

No you don't. A test fails if it doesn't return the value from the setter.

[kevmoo, 2015-03-24 13:10:53]

Committed patchset #1 (id:1) manually as
a286f690326c9f12511990e6fab3769365be4fea (presubmit successful).

[Lasse Reichstein Nielsen, 2015-03-24 18:38:11]

https://codereview.chromium.org/1028193003/diff/1/test/isolaterunner_test.dart
File test/isolaterunner_test.dart (right):

https://codereview.chromium.org/1028193003/diff/1/test/isolaterunner_test.dar...
test/isolaterunner_test.dart:114: setGlobal(v) => _global = v;
Ack, a "setter" with a meaningful return value. 
Maybe someone was a little too clever for his own good here :(