Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Issue 102763007: Function Decl formatter fixes (external and getters/setters) --- (dartbug.com/15914). (Closed)

Created:
6 years, 11 months ago by pquitslund
Modified:
6 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Function Decl formatter fixes (external and getters/setters) --- (dartbug.com/15914). R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=31491

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -4 lines) Patch
M pkg/analyzer/lib/src/services/formatter_impl.dart View 2 chunks +12 lines, -3 lines 0 comments Download
M pkg/analyzer/test/services/data/cu_tests.data View 1 chunk +15 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
pquitslund
6 years, 11 months ago (2014-01-06 17:41:28 UTC) #1
Brian Wilkerson
LGTM
6 years, 11 months ago (2014-01-06 17:49:43 UTC) #2
pquitslund
6 years, 11 months ago (2014-01-06 17:51:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r31491 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698