Fix constant evaluation of division.

Fix constant evaluation of division.

To be consistent with the VM and dart2js implementations, the
analyzer's constant evaluation of a / b should always yield a double,
even if the arguments are ints.  For example, 300 / 2 = 150.0 and 301
/ 2 = 150.5.

BUG=dartbug.com/22937
R=danrubel@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44645

[Paul Berry, 2015-03-23 16:09:11]

paulberry@google.com changed reviewers:
+ danrubel@google.com

[danrubel, 2015-03-23 16:48:49]

lgtm

https://codereview.chromium.org/1027453003/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/constant.dart (right):

https://codereview.chromium.org/1027453003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/constant.dart:2785: return UNKNOWN_VALUE;
DoubleState.UNKNOWN_VALUE ?

[Paul Berry, 2015-03-23 19:30:18]

https://codereview.chromium.org/1027453003/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/constant.dart (right):

https://codereview.chromium.org/1027453003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/constant.dart:2785: return UNKNOWN_VALUE;
On 2015/03/23 16:48:48, danrubel wrote:
> DoubleState.UNKNOWN_VALUE ?

This code is in the DoubleState class so it would be redundant.

[Paul Berry, 2015-03-23 19:36:44]

Committed patchset #1 (id:1) manually as 44645 (presubmit successful).