Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 1027433002: Temporarily move plugin support (Closed)

Created:
5 years, 9 months ago by Brian Wilkerson
Modified:
5 years, 9 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -467 lines) Patch
D pkg/analysis_server/lib/plugin/plugin.dart View 1 chunk +0 lines, -130 lines 0 comments Download
D pkg/analysis_server/lib/src/plugin/plugin_impl.dart View 1 chunk +0 lines, -125 lines 0 comments Download
M pkg/analysis_server/lib/src/plugin/server_plugin.dart View 2 chunks +1 line, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/server/driver.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/starter.dart View 1 chunk +1 line, -1 line 0 comments Download
D pkg/analysis_server/test/plugin/plugin_impl_test.dart View 1 chunk +0 lines, -174 lines 0 comments Download
D pkg/analysis_server/test/plugin/test_all.dart View 1 chunk +0 lines, -19 lines 0 comments Download
M pkg/analysis_server/test/socket_server_test.dart View 3 chunks +7 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/test_all.dart View 2 chunks +0 lines, -2 lines 0 comments Download
A + pkg/analyzer/lib/plugin/plugin.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analyzer/lib/src/plugin/plugin_impl.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/analyzer/test/plugin/plugin_impl_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/analyzer/test/plugin/test_all.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M pkg/analyzer/test/test_all.dart View 3 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
5 years, 9 months ago (2015-03-19 18:38:13 UTC) #2
scheglov
LGTM
5 years, 9 months ago (2015-03-19 18:39:14 UTC) #3
Brian Wilkerson
5 years, 9 months ago (2015-03-19 19:06:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44586 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698