Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1027383004: Evaluate expression before NSM (Closed)

Created:
5 years, 9 months ago by hausner
Modified:
5 years, 9 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Evaluate expression before NSM When assigning an expression to a final variable, evaluate the expression before throwing the NoSuchMethod error. This fixes issue 22936. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=44700

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -9 lines) Patch
M runtime/vm/parser.cc View 1 chunk +12 lines, -9 lines 0 comments Download
A tests/language/regress_22936_test.dart View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
hausner
5 years, 9 months ago (2015-03-25 20:57:13 UTC) #2
srdjan
lgtm
5 years, 9 months ago (2015-03-25 21:08:55 UTC) #3
hausner
5 years, 9 months ago (2015-03-25 21:45:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r44700 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698