Respect top-level @TestOn declarations.

Respect top-level @TestOn declarations.

Closes #6

R=kevmoo@google.com

Committed: https://github.com/dart-lang/unittest/commit/017aadabc9b06beaa58b227a8e0d2e0dfb52a305

[kevmoo, 2015-03-25 08:06:55]

LGTM – except

Now that we can run tests via chrome, there are failures in prints_test and
throws_test in Chrome.

I doubt these were introduced in this CL – although they don't seem to be
failing on the bots. Worth a look.

https://codereview.chromium.org/1027193004/diff/40001/lib/src/backend/platfor...
File lib/src/backend/platform_selector.dart (right):

https://codereview.chromium.org/1027193004/diff/40001/lib/src/backend/platfor...
lib/src/backend/platform_selector.dart:28: /// [the README]:
https://github.com/dart-lang/unittest/#platform-selector-syntax
nit: provide a shortname for the URL so it doesn't create a long line

https://codereview.chromium.org/1027193004/diff/40001/lib/src/frontend/test_o...
File lib/src/frontend/test_on.dart (right):

https://codereview.chromium.org/1027193004/diff/40001/lib/src/frontend/test_o...
lib/src/frontend/test_on.dart:11: /// [the README]:
https://github.com/dart-lang/unittest/#platform-selector-syntax
nit: The old format avoided the long line

[nweiz, 2015-03-25 22:40:55]

On 2015/03/25 08:06:55, kevmoo wrote:
> LGTM – except
> 
> Now that we can run tests via chrome, there are failures in prints_test and
> throws_test in Chrome.
> 
> I doubt these were introduced in this CL – although they don't seem to be
> failing on the bots. Worth a look.

The bots aren't running any browser tests, since the old way of running browser
tests no longer works and they have no integration with the new way yet.

Since these issues aren't caused by this CL, I'll fix them separately.

https://codereview.chromium.org/1027193004/diff/40001/lib/src/backend/platfor...
File lib/src/backend/platform_selector.dart (right):

https://codereview.chromium.org/1027193004/diff/40001/lib/src/backend/platfor...
lib/src/backend/platform_selector.dart:28: /// [the README]:
https://github.com/dart-lang/unittest/#platform-selector-syntax
On 2015/03/25 08:06:55, kevmoo wrote:
> nit: provide a shortname for the URL so it doesn't create a long line

I don't think there's any reason to try to shorten the name of the referent to
preserve line length when that's more dependent on the URL anyway; I don't want
to have to write "[a]" or whatever.

Long URLs in comments have always been an exception for line length
restrictions.

https://codereview.chromium.org/1027193004/diff/40001/lib/src/frontend/test_o...
File lib/src/frontend/test_on.dart (right):

https://codereview.chromium.org/1027193004/diff/40001/lib/src/frontend/test_o...
lib/src/frontend/test_on.dart:11: /// [the README]:
https://github.com/dart-lang/unittest/#platform-selector-syntax
On 2015/03/25 08:06:55, kevmoo wrote:
> nit: The old format avoided the long line

Ditto.

[nweiz, 2015-03-25 22:41:07]

Committed patchset #3 (id:40001) manually as
017aadabc9b06beaa58b227a8e0d2e0dfb52a305 (presubmit successful).