Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1026743002: Fix cancel behaviour of async* in dart2js. (Closed)

Created:
5 years, 9 months ago by sigurdm
Modified:
5 years, 9 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org, kasperl
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Fix cancel behaviour of async* in dart2js. Errors thrown in finallies after a cancel would be added to the stream (and thus suppressed) instead they now complete the future returned from cancel. BUG= dartbug.com/22912 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=44632

Patch Set 1 #

Patch Set 2 : Rename test, update status file #

Total comments: 2

Patch Set 3 : Address review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -8 lines) Patch
M sdk/lib/_internal/compiler/js_lib/js_helper.dart View 1 3 chunks +23 lines, -8 lines 0 comments Download
A tests/language/async_star_cancel_and_throw_in_finally_test.dart View 1 2 1 chunk +42 lines, -0 lines 0 comments Download
M tests/language/language.status View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
sigurdm
5 years, 9 months ago (2015-03-20 12:41:33 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/1026743002/diff/20001/tests/language/async_star_cancel_and_throw_in_finally_test.dart File tests/language/async_star_cancel_and_throw_in_finally_test.dart (right): https://codereview.chromium.org/1026743002/diff/20001/tests/language/async_star_cancel_and_throw_in_finally_test.dart#newcode32 tests/language/async_star_cancel_and_throw_in_finally_test.dart:32: Expect.equals("Error", e); Make sure this catch clause is ...
5 years, 9 months ago (2015-03-22 23:47:45 UTC) #3
sigurdm
Committed patchset #3 (id:40001) manually as 44632 (presubmit successful).
5 years, 9 months ago (2015-03-23 13:28:15 UTC) #4
sigurdm
5 years, 9 months ago (2015-03-23 13:45:16 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/1026743002/diff/20001/tests/language/async_st...
File tests/language/async_star_cancel_and_throw_in_finally_test.dart (right):

https://codereview.chromium.org/1026743002/diff/20001/tests/language/async_st...
tests/language/async_star_cancel_and_throw_in_finally_test.dart:32:
Expect.equals("Error", e);
On 2015/03/22 23:47:45, floitsch wrote:
> Make sure this catch clause is called.

Done.

Powered by Google App Engine
This is Rietveld 408576698