Change Multitest files to preserve line numbers.

Change Multitest files to preserve line numbers.

Instead of omitting multi-test parts that is not part of the current file,
an empty line is inserted instead.

Also move the "generated file, don't edit" warning line to the end of the file.

R=whesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44604

[Lasse Reichstein Nielsen, 2015-03-20 10:10:46]

lrn@google.com changed reviewers:
+ whesse@google.com

[Bill Hesse, 2015-03-20 10:32:57]

LGTM.

https://codereview.chromium.org/1026693002/diff/20001/tools/testing/dart/mult...
File tools/testing/dart/multitest.dart (right):

https://codereview.chromium.org/1026693002/diff/20001/tools/testing/dart/mult...
tools/testing/dart/multitest.dart:91: // Add the template, with no multitest
lines, as a test with key 'none'.
Maybe drop the testTemplate variable completely, and just use
testsAsLines['none']?

https://codereview.chromium.org/1026693002/diff/20001/tools/testing/dart/mult...
tools/testing/dart/multitest.dart:107: if (annotation.rest != 'continued') {
I think the code is clearer if we remove the testLines variable, move the loop
after, with a test in it:

outcomes.putIfAbsent(annotation.key, () => new Set<String>());
testsAsLines.putIfAbsent(annotation.key,
   () => new List<String>.from(testsAsLines['none']));
// Add an empty line to all the other tests, to preserve line numbers.
for (var key in testsAsLines.keys) {
  testsAsLines[key].add((key == annotation.key) ? line : "");
}

[Lasse Reichstein Nielsen, 2015-03-20 13:06:30]

https://codereview.chromium.org/1026693002/diff/20001/tools/testing/dart/mult...
File tools/testing/dart/multitest.dart (right):

https://codereview.chromium.org/1026693002/diff/20001/tools/testing/dart/mult...
tools/testing/dart/multitest.dart:91: // Add the template, with no multitest
lines, as a test with key 'none'.
On 2015/03/20 10:32:57, Bill Hesse wrote:
> Maybe drop the testTemplate variable completely, and just use
> testsAsLines['none']?

Done.

https://codereview.chromium.org/1026693002/diff/20001/tools/testing/dart/mult...
tools/testing/dart/multitest.dart:107: if (annotation.rest != 'continued') {
That is more readable. Done.

[Lasse Reichstein Nielsen, 2015-03-20 13:34:51]

Committed patchset #3 (id:40001) manually as 44604 (presubmit successful).