Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1025783002: Mark async and generator functions as debuggable, so their frames are visible for return type error… (Closed)

Created:
5 years, 9 months ago by rmacnak
Modified:
5 years, 9 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Mark async and generator functions as debuggable, so their frames are visible for return type errors during checked mode. BUG=http://dartbug.com/22891 R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=44614

Patch Set 1 #

Patch Set 2 : mark static warnings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -5 lines) Patch
M runtime/vm/parser.cc View 1 chunk +6 lines, -5 lines 0 comments Download
A tests/language/async_or_generator_return_type_stacktrace_test.dart View 1 1 chunk +35 lines, -0 lines 0 comments Download
M tests/language/language_analyzer.status View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rmacnak
5 years, 9 months ago (2015-03-20 20:41:59 UTC) #2
siva
lgtm
5 years, 9 months ago (2015-03-20 20:55:30 UTC) #3
rmacnak
5 years, 9 months ago (2015-03-20 21:50:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 44614 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698