Issue 1025633003: Revert "Mark async and generator functions as debuggable, so their frames are visible for return ty…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1025633003: Revert "Mark async and generator functions as debuggable, so their frames are visible for return ty… (Closed)

Created:
5 years, 9 months ago by rmacnak

Modified:
5 years, 9 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Revert "Mark async and generator functions as debuggable, so their frames are visible for return type errors during checked mode." This makes it impossible to set a breakpoint inside a async or generator body. TBR=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=44615

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -43 lines)			Patch
M	runtime/vm/parser.cc	View	1 chunk	+5 lines, -6 lines	0 comments	Download
D	tests/language/async_or_generator_return_type_stacktrace_test.dart	View	1 chunk	+0 lines, -35 lines	0 comments	Download
M	tests/language/language_analyzer.status	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rmacnak

Committed patchset #1 (id:1) manually as 44615 (presubmit successful).

5 years, 9 months ago (2015-03-20 22:02:06 UTC) #1

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages