|
Move implementation from IterableBase to Iterable.
Keep IterableBase around, but just extend Iterable.
There is no good reason to have IterableBase different from Iterable. The only argument is to be consistent with ListBase, but that's also inconsistent with, e.g., Stream.
ListBase only exists because List uses the default List constructor, so it's not a good super-class. As a usability-tradeoff, the ListBase class exists as a super-class.
Iterable doesn't have the same problem, so applying that "trade-off" has no up-side.
(A better long-term solution would be to be able to designate another constructor as the default "super()" constructor to call, so List could be used as a superclass).
R=sgjesse@google.com
Committed: https://code.google.com/p/dart/source/detail?r=45096
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+307 lines, -364 lines) |
Patch |
|
M |
runtime/vm/debugger_api_impl_test.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
sdk/lib/_internal/compiler/js_lib/collection_patch.dart
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
sdk/lib/_internal/compiler/js_lib/constant_map.dart
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
sdk/lib/_internal/compiler/js_lib/js_helper.dart
|
View
|
1
2
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
sdk/lib/_internal/compiler/js_lib/linked_hash_map.dart
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
sdk/lib/collection/iterable.dart
|
View
|
1
2
|
2 chunks |
+108 lines, -309 lines |
0 comments
|
Download
|
|
M |
sdk/lib/collection/linked_list.dart
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
sdk/lib/collection/maps.dart
|
View
|
1
|
3 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
|
M |
sdk/lib/collection/queue.dart
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
sdk/lib/collection/splay_tree.dart
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
sdk/lib/core/iterable.dart
|
View
|
|
21 chunks |
+172 lines, -28 lines |
0 comments
|
Download
|
|
M |
sdk/lib/core/set.dart
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
sdk/lib/core/string.dart
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
sdk/lib/internal/iterable.dart
|
View
|
|
9 chunks |
+9 lines, -9 lines |
0 comments
|
Download
|
Total messages: 5 (1 generated)
|