Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 1025573005: Move implementation from IterableBase to Iterable. (Closed)

Created:
5 years, 9 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 8 months ago
Reviewers:
Søren Gjesse, floitsch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Move implementation from IterableBase to Iterable. Keep IterableBase around, but just extend Iterable. There is no good reason to have IterableBase different from Iterable. The only argument is to be consistent with ListBase, but that's also inconsistent with, e.g., Stream. ListBase only exists because List uses the default List constructor, so it's not a good super-class. As a usability-tradeoff, the ListBase class exists as a super-class. Iterable doesn't have the same problem, so applying that "trade-off" has no up-side. (A better long-term solution would be to be able to designate another constructor as the default "super()" constructor to call, so List could be used as a superclass). R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=45096

Patch Set 1 #

Patch Set 2 : Move iterableToString implementation out of IterableBase class #

Patch Set 3 : Remove extra "static" on helper functions. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+307 lines, -364 lines) Patch
M runtime/vm/debugger_api_impl_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/js_lib/collection_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/js_lib/constant_map.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/js_lib/js_helper.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/js_lib/linked_hash_map.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/collection/iterable.dart View 1 2 2 chunks +108 lines, -309 lines 0 comments Download
M sdk/lib/collection/linked_list.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/collection/maps.dart View 1 3 chunks +5 lines, -5 lines 0 comments Download
M sdk/lib/collection/queue.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/collection/splay_tree.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M sdk/lib/core/iterable.dart View 21 chunks +172 lines, -28 lines 0 comments Download
M sdk/lib/core/set.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/string.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/internal/iterable.dart View 9 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Lasse Reichstein Nielsen
5 years, 9 months ago (2015-03-23 11:46:48 UTC) #2
Lasse Reichstein Nielsen
ping
5 years, 8 months ago (2015-04-08 09:10:53 UTC) #3
Søren Gjesse
lgtm
5 years, 8 months ago (2015-04-08 09:44:58 UTC) #4
Lasse Reichstein Nielsen
5 years, 8 months ago (2015-04-13 12:26:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 45096 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698