Issue 102543006: Use TypedArray.set for setRange of between similarly typed lists implemented as TypedArrays

Issue 102543006: Use TypedArray.set for setRange of between similarly typed lists implemented as TypedArrays (Closed)

Created:
7 years ago by sra1

Modified:
7 years ago

Reviewers:
Cutch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Use TypedArray.set for setRange of between similarly typed lists implemented as TypedArrays R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=30867

Patch Set 2 : #

Total comments: 4

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -50 lines)			Patch
	M	sdk/lib/typed_data/dart2js/typed_data_dart2js.dart	View	1	18 chunks	+77 lines, -49 lines	2 comments	Download
	M	tests/lib/lib.status	View		1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Cutch

https://codereview.chromium.org/102543006/diff/60001/sdk/lib/typed_data/dart2js/typed_data_dart2js.dart File sdk/lib/typed_data/dart2js/typed_data_dart2js.dart (right): https://codereview.chromium.org/102543006/diff/60001/sdk/lib/typed_data/dart2js/typed_data_dart2js.dart#newcode460 sdk/lib/typed_data/dart2js/typed_data_dart2js.dart:460: // TODO(sra): Hide this type. Why not just _NativeTypedArray, ...

7 years ago (2013-12-04 17:50:02 UTC) #2

sra1

7 years ago (2013-12-04 20:52:50 UTC) #5

Message was sent while issue was closed.

https://chromiumcodereview.appspot.com/102543006/diff/60001/sdk/lib/typed_dat...
File sdk/lib/typed_data/dart2js/typed_data_dart2js.dart (right):

https://chromiumcodereview.appspot.com/102543006/diff/60001/sdk/lib/typed_dat...
sdk/lib/typed_data/dart2js/typed_data_dart2js.dart:460: // TODO(sra): Hide this
type.
On 2013/12/04 17:50:02, Cutch wrote:
> Why not just _NativeTypedArray, _NativeTypedArrayOfDouble, etc today?

I will do that for now, but ultimately other libraries (e.g. html postMessage)
will need to test for the real native implementations and tell them apart from
classes that just 'implement' one of the typed data classes.

https://chromiumcodereview.appspot.com/102543006/diff/60001/tests/lib/lib.status
File tests/lib/lib.status (right):

https://chromiumcodereview.appspot.com/102543006/diff/60001/tests/lib/lib.sta...
tests/lib/lib.status:84: #typed_data/typed_data_setRange_test: Fail # Issues
15134, 15412
On 2013/12/04 17:50:02, Cutch wrote:
> Why not remove this instead of commenting out?

Done.

Expand Messages | Collapse Messages