Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1025293003: pkg/isolate: library renaming, removed unused method, fix creation of TimeoutException (Closed)

Created:
5 years, 9 months ago by kevmoo
Modified:
5 years, 9 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/isolate.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

library renaming, removed unused method, fix creation of TimeoutException R=lrn@google.com Committed: https://github.com/dart-lang/isolate/commit/65dc0c6f5f5f5a5d86490e9a1c6e586f20ac2ca1

Patch Set 1 #

Total comments: 16

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -919 lines) Patch
M CHANGELOG.md View 1 chunk +7 lines, -5 lines 0 comments Download
M README.md View 2 chunks +2 lines, -2 lines 0 comments Download
D example/http-server.dart View 1 chunk +0 lines, -115 lines 0 comments Download
A + example/http_server.dart View 1 chunk +5 lines, -4 lines 0 comments Download
D example/runner-pool.dart View 1 chunk +0 lines, -57 lines 0 comments Download
A + example/runner_pool.dart View 1 chunk +5 lines, -4 lines 0 comments Download
M lib/isolate.dart View 1 chunk +6 lines, -6 lines 0 comments Download
A + lib/isolate_runner.dart View 1 2 chunks +6 lines, -6 lines 0 comments Download
D lib/isolaterunner.dart View 1 chunk +0 lines, -297 lines 0 comments Download
A + lib/load_balancer.dart View 1 chunk +6 lines, -5 lines 0 comments Download
D lib/loadbalancer.dart View 1 chunk +0 lines, -280 lines 0 comments Download
M lib/ports.dart View 1 2 chunks +5 lines, -3 lines 0 comments Download
M lib/registry.dart View 1 chunk +7 lines, -6 lines 0 comments Download
M lib/runner.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/src/errors.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/src/lists.dart View 1 chunk +1 line, -1 line 0 comments Download
D lib/src/multiplexport.dart View 1 chunk +0 lines, -101 lines 0 comments Download
A + lib/src/raw_receive_port_multiplexer.dart View 1 chunk +6 lines, -5 lines 0 comments Download
M pubspec.yaml View 1 1 chunk +3 lines, -5 lines 0 comments Download
M test/isolaterunner_test.dart View 1 1 chunk +5 lines, -4 lines 0 comments Download
M test/ports_test.dart View 1 chunk +5 lines, -4 lines 0 comments Download
M test/registry_test.dart View 1 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
kevmoo
5 years, 9 months ago (2015-03-23 14:56:44 UTC) #2
Lasse Reichstein Nielsen
lgtm https://codereview.chromium.org/1025293003/diff/1/README.md File README.md (right): https://codereview.chromium.org/1025293003/diff/1/README.md#newcode14 README.md:14: The "isolate_runner.dart" sub-library introduces an `IsolateRunner` class Aw, ...
5 years, 9 months ago (2015-03-24 10:35:39 UTC) #3
kevmoo
https://codereview.chromium.org/1025293003/diff/1/README.md File README.md (right): https://codereview.chromium.org/1025293003/diff/1/README.md#newcode14 README.md:14: The "isolate_runner.dart" sub-library introduces an `IsolateRunner` class On 2015/03/24 ...
5 years, 9 months ago (2015-03-24 13:21:19 UTC) #4
kevmoo
5 years, 9 months ago (2015-03-24 13:21:33 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
65dc0c6f5f5f5a5d86490e9a1c6e586f20ac2ca1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698