Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 102473004: Make the global port a "weak" port. (Closed)

Created:
7 years ago by floitsch
Modified:
7 years ago
CC:
reviews_dartlang.org, ngeoffray
Visibility:
Public.

Description

Make the global port a "weak" port. We could have just removed all references to the lazyPort, but this CL prepares for using the lazyPort as controlPort. BUG= http://dartbug.com/14461 R=lrn@google.com, ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=30938

Patch Set 1 #

Patch Set 2 : Rename lazyPort to controlPort. #

Total comments: 2

Patch Set 3 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -20 lines) Patch
M sdk/lib/_internal/lib/isolate_helper.dart View 1 2 6 chunks +41 lines, -18 lines 0 comments Download
M sdk/lib/_internal/lib/isolate_patch.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
M tests/isolate/isolate.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
floitsch
7 years ago (2013-12-05 16:28:08 UTC) #1
ngeoffray
LGTM https://codereview.chromium.org/102473004/diff/20001/sdk/lib/_internal/lib/isolate_helper.dart File sdk/lib/_internal/lib/isolate_helper.dart (right): https://codereview.chromium.org/102473004/diff/20001/sdk/lib/_internal/lib/isolate_helper.dart#newcode240 sdk/lib/_internal/lib/isolate_helper.dart:240: isolateStatics = JS_CREATE_ISOLATE(); Mark all the fields final ...
7 years ago (2013-12-05 16:32:23 UTC) #2
floitsch
https://codereview.chromium.org/102473004/diff/20001/sdk/lib/_internal/lib/isolate_helper.dart File sdk/lib/_internal/lib/isolate_helper.dart (right): https://codereview.chromium.org/102473004/diff/20001/sdk/lib/_internal/lib/isolate_helper.dart#newcode240 sdk/lib/_internal/lib/isolate_helper.dart:240: isolateStatics = JS_CREATE_ISOLATE(); On 2013/12/05 16:32:23, ngeoffray wrote: > ...
7 years ago (2013-12-05 17:08:35 UTC) #3
Lasse Reichstein Nielsen
LGTM. Is weak ports something we would want to expose to users?
7 years ago (2013-12-06 08:00:03 UTC) #4
floitsch
7 years ago (2013-12-06 09:32:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r30938 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698