Issue 1024563003: Clean up apply2-test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1024563003: Clean up apply2-test. (Closed)

Created:
5 years, 9 months ago by Lasse Reichstein Nielsen

Modified:
5 years, 9 months ago

Reviewers:
herhut

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

Clean up apply2-test. It was quite unreadable. Committed: https://code.google.com/p/dart/source/detail?r=44679

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -79 lines)			Patch
	M	tests/corelib/apply2_test.dart	View	1	2 chunks	+70 lines, -79 lines	0 comments	Download

Total messages: 5 (1 generated)

herhut

Much much nicer to read. Thank you! While you are at it, could you add ...

5 years, 9 months ago (2015-03-23 14:42:56 UTC) #3

Lasse Reichstein Nielsen

I have added the case, and dart2js is currently failing the extra test.

5 years, 9 months ago (2015-03-24 13:01:05 UTC) #4

Lasse Reichstein Nielsen

5 years, 9 months ago (2015-03-25 07:02:20 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 44679 (presubmit successful).