Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 102453002: VM debugger: fix closures in mixed-in functions (Closed)

Created:
7 years ago by hausner
Modified:
7 years ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Jacob
Visibility:
Public.

Description

VM debugger: fix closures in mixed-in functions Avoid assertion in debugger when compiling closures in mixin functions. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=30823

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -9 lines) Patch
M runtime/vm/debugger.cc View 2 chunks +16 lines, -2 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/debugger/debug_lib.dart View 1 3 chunks +9 lines, -6 lines 0 comments Download
A tests/standalone/debugger/mixin_closure_debugger_test.dart View 1 2 1 chunk +54 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hausner
7 years ago (2013-12-03 17:45:56 UTC) #1
siva
lgtm
7 years ago (2013-12-03 18:40:47 UTC) #2
hausner
Committed patchset #3 manually as r30823 (presubmit successful).
7 years ago (2013-12-03 19:19:59 UTC) #3
hausner
7 years ago (2013-12-03 19:23:30 UTC) #4
Message was sent while issue was closed.
Thank you. Also added a regression test.

Powered by Google App Engine
This is Rietveld 408576698