Add lots of debugging machinery for flaky datetime creation

Add lots of debugging machinery for flaky datetime creation

R=kustermann@google.com

Committed: https://code.google.com/p/dart/source/detail?r=31234

[Alan Knight, 2013-12-17 22:10:31]

This puts logging as close as possible to the actual date creation, which
requires adding some temporary debug variables to communicate it back to the
tests, so hopefully we can leave this in for as short a time as possible. It
also adds a re-parse check.

[kustermann, 2013-12-18 08:44:50]

LGTM

Btw: We hit another one of these:
  "FAIL: Test round-trip parsing of dates\n  Expected: '27/9/2012'\n    Actual:
'26/9/2012'\n
  ....
http://build.chromium.org/p/client.dart/builders/dartium-lucid32-full-be/buil...

https://codereview.chromium.org/102443007/diff/1/pkg/intl/lib/src/temporary_d...
File pkg/intl/lib/src/temporary_debugging.dart (right):

https://codereview.chromium.org/102443007/diff/1/pkg/intl/lib/src/temporary_d...
pkg/intl/lib/src/temporary_debugging.dart:10: StringBuffer dateCreationLog = new
StringBuffer();
You could rename these two to include "debug" to make it crystal clear, that
this is only used for debugging purposes, e.g.:

bool  debugLogDateCreation = false;
StringBuffer debugDateCreationLog = new StringBuffer();


Alternatively you could use prefix imports in the other file:
 import 'package:intl/src/temporary_debugging.dart' as debug;
 debug.logDateCreation = ...

https://codereview.chromium.org/102443007/diff/1/pkg/intl/test/date_time_form...
File pkg/intl/test/date_time_format_test_core.dart (right):

https://codereview.chromium.org/102443007/diff/1/pkg/intl/test/date_time_form...
pkg/intl/test/date_time_format_test_core.dart:169: var parsed =
format.parse("actualResult");
Was this quoting an accident?

https://codereview.chromium.org/102443007/diff/1/pkg/intl/test/date_time_form...
pkg/intl/test/date_time_format_test_core.dart:184: logDateCreation = true;
This is already set on line 168 and unset on line 197.
I think you can safely remove it here.

[Alan Knight, 2013-12-18 17:49:17]

https://codereview.chromium.org/102443007/diff/1/pkg/intl/lib/src/temporary_d...
File pkg/intl/lib/src/temporary_debugging.dart (right):

https://codereview.chromium.org/102443007/diff/1/pkg/intl/lib/src/temporary_d...
pkg/intl/lib/src/temporary_debugging.dart:10: StringBuffer dateCreationLog = new
StringBuffer();
On 2013/12/18 08:44:50, kustermann wrote:
> You could rename these two to include "debug" to make it crystal clear, that
> this is only used for debugging purposes, e.g.:
> 
> bool  debugLogDateCreation = false;
> StringBuffer debugDateCreationLog = new StringBuffer();
> 
> 
> Alternatively you could use prefix imports in the other file:
>  import 'package:intl/src/temporary_debugging.dart' as debug;
>  debug.logDateCreation = ...

Done.

https://codereview.chromium.org/102443007/diff/1/pkg/intl/test/date_time_form...
File pkg/intl/test/date_time_format_test_core.dart (right):

https://codereview.chromium.org/102443007/diff/1/pkg/intl/test/date_time_form...
pkg/intl/test/date_time_format_test_core.dart:169: var parsed =
format.parse("actualResult");
On 2013/12/18 08:44:50, kustermann wrote:
> Was this quoting an accident?

Oops, thanks. Done.

https://codereview.chromium.org/102443007/diff/1/pkg/intl/test/date_time_form...
pkg/intl/test/date_time_format_test_core.dart:184: logDateCreation = true;
On 2013/12/18 08:44:50, kustermann wrote:
> This is already set on line 168 and unset on line 197.
> I think you can safely remove it here.

Done.

[Alan Knight, 2013-12-18 17:50:29]

Committed patchset #2 manually as r31234 (presubmit successful).