Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 1024063003: Eliminate fake-Isolate workaround from concurrent sweeper. (Closed)

Created:
5 years, 9 months ago by koda
Modified:
5 years, 9 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Eliminate fake-Isolate workaround from concurrent sweeper. Add RawObject::Size(ClassTable*) to avoid remaning calls to Isolate::Current. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=44611

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -99 lines) Patch
M runtime/vm/gc_marker.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/gc_sweeper.h View 3 chunks +6 lines, -1 line 0 comments Download
M runtime/vm/gc_sweeper.cc View 7 chunks +12 lines, -15 lines 0 comments Download
M runtime/vm/isolate.h View 2 chunks +0 lines, -3 lines 0 comments Download
M runtime/vm/isolate.cc View 4 chunks +11 lines, -74 lines 0 comments Download
M runtime/vm/pages.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/raw_object.h View 3 chunks +15 lines, -0 lines 0 comments Download
M runtime/vm/raw_object.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
koda
5 years, 9 months ago (2015-03-20 16:54:06 UTC) #1
Ivan Posva
LGTM -ip
5 years, 9 months ago (2015-03-20 18:41:46 UTC) #2
koda
5 years, 9 months ago (2015-03-20 20:37:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as r44611 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698