Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1023893003: Make tools/gypdart independent of the directory from which it is called. (Closed)

Created:
5 years, 9 months ago by ricow1
Modified:
5 years, 9 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Make tools/gypdart independent of the directory from which it is called. This enables more independence in the way you can structure your checkout using gclient. BUG= R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=44640

Patch Set 1 #

Patch Set 2 : move dir constants to top level #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M tools/gyp_dart.py View 1 2 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ricow1
5 years, 9 months ago (2015-03-23 17:23:43 UTC) #2
ahe
lgtm
5 years, 9 months ago (2015-03-23 17:40:22 UTC) #3
ricow1
5 years, 9 months ago (2015-03-23 17:44:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 44640 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698