Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 102373007: Fix mutation observer test bug dartbug.com/15497 (Closed)

Created:
7 years ago by Jacob
Modified:
7 years ago
Reviewers:
blois
CC:
reviews_dartlang.org, ahe, Bill Hesse, rafaelw1
Visibility:
Public.

Description

Fix mutation observer test bug dartbug.com/15497 BUG= R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=31143

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M tests/html/html.status View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/html/mutationobserver_test.dart View 4 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jacob
I believe the problem was v8 was GCing the Node with attached mutation observers before ...
7 years ago (2013-12-13 03:13:27 UTC) #1
Jacob
7 years ago (2013-12-13 19:05:43 UTC) #2
blois
lgtm
7 years ago (2013-12-13 19:26:46 UTC) #3
Jacob
Committed patchset #1 manually as r31143 (presubmit successful).
7 years ago (2013-12-13 19:29:08 UTC) #4
Jacob
7 years ago (2013-12-17 02:49:15 UTC) #5
Message was sent while issue was closed.
This reproduces outside of content_shell.  Filed a bug at
https://code.google.com/p/chromium/issues/detail?id=329103

Powered by Google App Engine
This is Rietveld 408576698