Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1023673012: Emit diagnostics for bad NSM implementations (Closed)

Created:
5 years, 9 months ago by Harry Terkelsen
Modified:
5 years, 8 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org, floitsch
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Emit diagnostics for bad NSM implementations BUG= R=sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=44808

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : be more precise about types #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -25 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 1 2 3 4 3 chunks +4 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 2 3 4 3 chunks +7 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/no_such_method_registry.dart View 1 2 3 4 4 chunks +65 lines, -23 lines 0 comments Download
M pkg/compiler/lib/src/warnings.dart View 1 2 3 4 1 chunk +22 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/no_such_method_enabled_test.dart View 2 chunks +53 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Harry Terkelsen
5 years, 9 months ago (2015-03-25 22:08:58 UTC) #2
Harry Terkelsen
Ping?
5 years, 8 months ago (2015-03-30 23:29:23 UTC) #3
sra1
lgtm https://codereview.chromium.org/1023673012/diff/60001/pkg/compiler/lib/src/compiler.dart File pkg/compiler/lib/src/compiler.dart (right): https://codereview.chromium.org/1023673012/diff/60001/pkg/compiler/lib/src/compiler.dart#newcode294 pkg/compiler/lib/src/compiler.dart:294: void onInferenceComplete() {} onTypeInferenceComplete() we could add other ...
5 years, 8 months ago (2015-03-31 02:19:15 UTC) #4
Harry Terkelsen
5 years, 8 months ago (2015-03-31 17:12:14 UTC) #5
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as 44808 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698