Make dartj2s do type conversions on constructor arguments

Make dartj2s do type conversions on constructor arguments

BUG=
R=terry@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44688

[Alan Knight, 2015-03-20 23:51:58]

alanknight@google.com changed reviewers:
+ sra@google.com, terry@google.com

[Alan Knight, 2015-03-20 23:51:58]

This fixes Notification properly, so it undoes the template fix I had originally
put in. It also fixes a number of other things, most of them experimental. I
added a test for FontFace, which was one we already had at least some level of
testing for. Some of the other changes are just parameter renames, because I
extracted out the logic for doing type conversions into a separate method and
now some variable names get re-used.

[terry, 2015-03-23 14:45:59]

Nice change surprised how many dictionary constructors were not correctly being
handled.  Seems like we might need more tests since so many things wouldn't be
working.

https://codereview.chromium.org/1023363002/diff/20001/sdk/lib/html/dart2js/ht...
File sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/1023363002/diff/20001/sdk/lib/html/dart2js/ht...
sdk/lib/html/dart2js/html_dart2js.dart:29887: +      List protocols_1 =
convertDartToNative_StringArray(protocol_OR_protocols);
Currently this is a NOOP returns what is passed in.  Is this really necessary or
is this some optimization that Stephen may need in the future?

https://codereview.chromium.org/1023363002/diff/20001/tools/dom/scripts/syste...
File tools/dom/scripts/systemhtml.py (right):

https://codereview.chromium.org/1023363002/diff/20001/tools/dom/scripts/syste...
tools/dom/scripts/systemhtml.py:1065: return self._InputType(type_name, info)
Why does InputType exist can't you just all use _InputType?

[terry, 2015-03-23 14:46:25]

On 2015/03/23 14:45:59, terry wrote:
> Nice change surprised how many dictionary constructors were not correctly
being
> handled.  Seems like we might need more tests since so many things wouldn't be
> working.
> 
>
https://codereview.chromium.org/1023363002/diff/20001/sdk/lib/html/dart2js/ht...
> File sdk/lib/html/dart2js/html_dart2js.dart (right):
> 
>
https://codereview.chromium.org/1023363002/diff/20001/sdk/lib/html/dart2js/ht...
> sdk/lib/html/dart2js/html_dart2js.dart:29887: +      List protocols_1 =
> convertDartToNative_StringArray(protocol_OR_protocols);
> Currently this is a NOOP returns what is passed in.  Is this really necessary
or
> is this some optimization that Stephen may need in the future?
> 
>
https://codereview.chromium.org/1023363002/diff/20001/tools/dom/scripts/syste...
> File tools/dom/scripts/systemhtml.py (right):
> 
>
https://codereview.chromium.org/1023363002/diff/20001/tools/dom/scripts/syste...
> tools/dom/scripts/systemhtml.py:1065: return self._InputType(type_name, info)
> Why does InputType exist can't you just all use _InputType?

lgtm

[Alan Knight, 2015-03-23 18:00:12]

A lot of the things that were missing conversions are still early stage
experimental. I did look at writing tests for some, but they're often
Chrome-only and seem likely to change, so I ended up doing just Notification and
FontFace.

https://codereview.chromium.org/1023363002/diff/20001/sdk/lib/html/dart2js/ht...
File sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/1023363002/diff/20001/sdk/lib/html/dart2js/ht...
sdk/lib/html/dart2js/html_dart2js.dart:29887: +      List protocols_1 =
convertDartToNative_StringArray(protocol_OR_protocols);
On 2015/03/23 14:45:59, terry wrote:
> Currently this is a NOOP returns what is passed in.  Is this really necessary
or
> is this some optimization that Stephen may need in the future?

I don't know. I'm just calling the same type conversion that gets done for
instance methods, and it picks this one up. Hopefully the compiler knows enough
to compile away the NOOP.

https://codereview.chromium.org/1023363002/diff/20001/tools/dom/scripts/syste...
File tools/dom/scripts/systemhtml.py (right):

https://codereview.chromium.org/1023363002/diff/20001/tools/dom/scripts/syste...
tools/dom/scripts/systemhtml.py:1065: return self._InputType(type_name, info)
On 2015/03/23 14:45:59, terry wrote:
> Why does InputType exist can't you just all use _InputType?

I have to pass it as a closure, so I needed something that was already bound to
self. Maybe there's a cleverer way to do that in Python?

[sra1, 2015-03-23 21:49:16]

https://codereview.chromium.org/1023363002/diff/20001/sdk/lib/html/dart2js/ht...
File sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/1023363002/diff/20001/sdk/lib/html/dart2js/ht...
sdk/lib/html/dart2js/html_dart2js.dart:29887: +      List protocols_1 =
convertDartToNative_StringArray(protocol_OR_protocols);
On 2015/03/23 14:45:59, terry wrote:
> Currently this is a NOOP returns what is passed in.  Is this really necessary
or
> is this some optimization that Stephen may need in the future?

Leave it in.  It is unimplemented but needed if the argument is a different kind
of List than JSArray, in which case it needs to be converted to a JSArray. 
convertDartToNative_StringArray should also ensure the contents are strings and
not null or something crazy.

[Alan Knight, 2015-03-25 17:45:05]

Committed patchset #2 (id:20001) manually as 44688 (presubmit successful).