Issue 1022843002: Rewrite ImplicitConstructorBuilder to use only element model.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1022843002: Rewrite ImplicitConstructorBuilder to use only element model. (Closed)

Created:
5 years, 9 months ago by scheglov

Modified:
5 years, 9 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Rewrite ImplicitConstructorBuilder to use only element model. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=44583

Patch Set 1 #

Total comments: 2

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+162 lines, -195 lines)			Patch
M	pkg/analyzer/lib/src/generated/element.dart	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/resolver.dart	View	12 chunks	+95 lines, -139 lines	2 comments	Download
M	pkg/analyzer/lib/src/generated/testing/element_factory.dart	View	3 chunks	+16 lines, -6 lines	0 comments	Download
M	pkg/analyzer/test/generated/resolver_test.dart	View	20 chunks	+46 lines, -50 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/1022843002/diff/1/pkg/analyzer/lib/src/generated/resolver.dart File pkg/analyzer/lib/src/generated/resolver.dart (right): https://codereview.chromium.org/1022843002/diff/1/pkg/analyzer/lib/src/generated/resolver.dart#newcode4876 pkg/analyzer/lib/src/generated/resolver.dart:4876: class ImplicitConstructorBuilder extends RecursiveElementVisitor { This doesn't need ...

5 years, 9 months ago (2015-03-19 17:57:31 UTC) #2

scheglov

5 years, 9 months ago (2015-03-19 18:11:42 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 44583 (presubmit successful).

Expand Messages | Collapse Messages