Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1022483002: Added more diag info (Closed)

Created:
5 years, 9 months ago by terry
Modified:
5 years, 9 months ago
Reviewers:
vsm, Alan Knight
CC:
reviews_dartlang.org, ricow1
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -8 lines) Patch
M tools/dom/scripts/databasebuilder.py View 1 4 chunks +32 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
terry
5 years, 9 months ago (2015-03-18 19:07:30 UTC) #2
Alan Knight
lgtm https://codereview.chromium.org/1022483002/diff/1/tools/dom/scripts/databasebuilder.py File tools/dom/scripts/databasebuilder.py (right): https://codereview.chromium.org/1022483002/diff/1/tools/dom/scripts/databasebuilder.py#newcode856 tools/dom/scripts/databasebuilder.py:856: self._tabluate(['%s%s' % (dictionary.id, ' (New)' if any_constructors else ...
5 years, 9 months ago (2015-03-18 19:13:03 UTC) #3
terry
https://codereview.chromium.org/1022483002/diff/1/tools/dom/scripts/databasebuilder.py File tools/dom/scripts/databasebuilder.py (right): https://codereview.chromium.org/1022483002/diff/1/tools/dom/scripts/databasebuilder.py#newcode856 tools/dom/scripts/databasebuilder.py:856: self._tabluate(['%s%s' % (dictionary.id, ' (New)' if any_constructors else ''), ...
5 years, 9 months ago (2015-03-18 19:22:36 UTC) #4
terry
5 years, 9 months ago (2015-03-18 19:23:03 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 44562 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698