Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1191)

Issue 1022103002: Do not include names of lazy globals in minified mode. (Closed)

Created:
5 years, 9 months ago by herhut
Modified:
5 years, 8 months ago
Reviewers:
zarah
CC:
reviews_dartlang.org, floitsch
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Do not include names of lazy globals in minified mode. BUG= R=zarah@google.com Committed: https://code.google.com/p/dart/source/detail?r=44777

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -11 lines) Patch
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 1 3 chunks +26 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
herhut
This saves 14k at the expense of a less readable error message. However, you still ...
5 years, 9 months ago (2015-03-20 14:28:42 UTC) #2
zarah
LGTM
5 years, 9 months ago (2015-03-20 14:32:33 UTC) #3
herhut
5 years, 8 months ago (2015-03-30 10:36:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 44777 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698