Issue 1021833002: Avoid needless calls to Isolate::Current() in RawObject::SizeFromClass.

Issue 1021833002: Avoid needless calls to Isolate::Current() in RawObject::SizeFromClass. (Closed)

Created:
5 years, 9 months ago by koda

Modified:
5 years, 9 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Avoid needless calls to Isolate::Current() in RawObject::SizeFromClass. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=44610

Patch Set 2 : #

Total comments: 1

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+133 lines, -138 lines)			Patch
	M	runtime/vm/raw_object.cc	View	1	1 chunk	+133 lines, -138 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

https://codereview.chromium.org/1021833002/diff/1/runtime/vm/raw_object.cc File runtime/vm/raw_object.cc (right): https://codereview.chromium.org/1021833002/diff/1/runtime/vm/raw_object.cc#newcode77 runtime/vm/raw_object.cc:77: Code::PtrOffBits::decode(raw_code->ptr()->state_bits_); 4 spaces

5 years, 9 months ago (2015-03-19 23:19:36 UTC) #2

koda

5 years, 9 months ago (2015-03-19 23:22:38 UTC) #3

Ivan Posva

LGTM -ip https://codereview.chromium.org/1021833002/diff/20001/runtime/vm/raw_object.cc File runtime/vm/raw_object.cc (right): https://codereview.chromium.org/1021833002/diff/20001/runtime/vm/raw_object.cc#newcode193 runtime/vm/raw_object.cc:193: // Get the (constant) instance size out ...

5 years, 9 months ago (2015-03-20 18:36:43 UTC) #4

koda

5 years, 9 months ago (2015-03-20 20:19:20 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as r44610 (presubmit successful).

Expand Messages | Collapse Messages