Issue 102123010: Add getter for hasTerminal, terminalColumns and terminalLines on stdout.

Issue 102123010: Add getter for hasTerminal, terminalColumns and terminalLines on stdout. (Closed)

Created:
7 years ago by Anders Johnsen

Modified:
7 years ago

Reviewers:
zra, Søren Gjesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add getter for hasTerminal, terminalColumns and terminalLines on stdin. BUG=https://code.google.com/p/dart/issues/detail?id=15557 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=31255

Patch Set 1 #

Patch Set 2 : Windows impl. #

Patch Set 3 : Move from Stdin to Stdout. #

Patch Set 4 : Add include of thread.h and fix io_patch. #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+236 lines, -406 lines)			Patch
M	runtime/bin/io_impl_sources.gypi	View	1 2	1 chunk	+6 lines, -6 lines	0 comments	Download
M	runtime/bin/io_natives.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/bin/signal_blocker.h	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/bin/stdin.h	View	1 2	1 chunk	+0 lines, -36 lines	0 comments	Download
M	runtime/bin/stdin.cc	View	1 2	1 chunk	+0 lines, -47 lines	0 comments	Download
D	runtime/bin/stdin_android.cc	View	1 2	1 chunk	+0 lines, -69 lines	0 comments	Download
M	runtime/bin/stdin_linux.cc	View	1 2	1 chunk	+0 lines, -69 lines	0 comments	Download
D	runtime/bin/stdin_macos.cc	View	1 2	1 chunk	+0 lines, -69 lines	0 comments	Download
M	runtime/bin/stdin_win.cc	View	1 2	1 chunk	+0 lines, -70 lines	0 comments	Download
A +	runtime/bin/stdio.h	View	1 2	2 chunks	+13 lines, -3 lines	0 comments	Download
A +	runtime/bin/stdio.cc	View	1 2	2 chunks	+14 lines, -1 line	0 comments	Download
A +	runtime/bin/stdio_android.cc	View	1 2	1 chunk	+24 lines, -9 lines	0 comments	Download
A +	runtime/bin/stdio_linux.cc	View	1 2	1 chunk	+24 lines, -9 lines	0 comments	Download
A +	runtime/bin/stdio_macos.cc	View	1 2	2 chunks	+23 lines, -9 lines	0 comments	Download
M	runtime/bin/stdio_patch.dart	View	1 2	2 chunks	+34 lines, -3 lines	0 comments	Download
A +	runtime/bin/stdio_win.cc	View	1 2	2 chunks	+11 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/lib/io_patch.dart	View	1 2 3	2 chunks	+13 lines, -1 line	0 comments	Download
M	sdk/lib/io/stdio.dart	View	1 2	4 chunks	+46 lines, -3 lines	0 comments	Download
M	tests/standalone/io/stdin_sync_test.dart	View	1 2	3 chunks	+3 lines, -1 line	0 comments	Download
A	tests/standalone/io/stdout_test.dart	View	1 2	1 chunk	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

zra

As discussed. Builds on Android with addition of platform/thread.h to signal_blocker.h

7 years ago (2013-12-18 19:57:09 UTC) #2

Anders Johnsen

7 years ago (2013-12-19 11:00:20 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r31255 (presubmit successful).

Expand Messages | Collapse Messages