Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 1020893004: Be less aggressive in sharing contexts between scopes so that sibling contexts (Closed)

Created:
5 years, 9 months ago by regis
Modified:
5 years, 9 months ago
Reviewers:
srdjan, hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Ivan Posva
Visibility:
Public.

Description

Be less aggressive in sharing contexts between scopes so that sibling contexts cannot appear in nested node sequences (issue 22858), since this case cannot be handled by the graph builder. Add assert to graph builder to detect such occurences (uncovered async* bug). Fix an async* issue where a scope was mistakenly reused. Improve ast printing for node sequences. Add regression test. R=hausner@google.com, srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=44592

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -58 lines) Patch
M runtime/vm/ast_printer.cc View 1 chunk +13 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_builder.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M runtime/vm/object_test.cc View 1 chunk +1 line, -5 lines 0 comments Download
M runtime/vm/parser.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M runtime/vm/parser_test.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M runtime/vm/scopes.h View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/scopes.cc View 5 chunks +26 lines, -34 lines 0 comments Download
A tests/language/regress_22858_test.dart View 1 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
regis
5 years, 9 months ago (2015-03-19 22:06:08 UTC) #2
hausner
LGTM.
5 years, 9 months ago (2015-03-19 22:32:55 UTC) #3
srdjan
lgtm https://codereview.chromium.org/1020893004/diff/1/tests/language/regress_22858_test.dart File tests/language/regress_22858_test.dart (right): https://codereview.chromium.org/1020893004/diff/1/tests/language/regress_22858_test.dart#newcode24 tests/language/regress_22858_test.dart:24: f1(); Indent 2 spaces
5 years, 9 months ago (2015-03-19 22:34:44 UTC) #4
regis
Thank you both! https://codereview.chromium.org/1020893004/diff/1/tests/language/regress_22858_test.dart File tests/language/regress_22858_test.dart (right): https://codereview.chromium.org/1020893004/diff/1/tests/language/regress_22858_test.dart#newcode24 tests/language/regress_22858_test.dart:24: f1(); On 2015/03/19 22:34:44, srdjan wrote: ...
5 years, 9 months ago (2015-03-19 22:38:53 UTC) #5
regis
5 years, 9 months ago (2015-03-19 22:39:56 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as r44592 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698